Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip doc build-kind on 1.45.0 and lower versions #697

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Skip doc build-kind on 1.45.0 and lower versions #697

merged 1 commit into from
Jul 20, 2020

Conversation

Mark-Simulacrum
Copy link
Member

Fixes #696

jyn514
jyn514 reviewed Jul 20, 2020
View reviewed changes
collector/src/lib.rs
if let Some(version) = version_str.parse::<semver::Version>().ok() {
version >= semver::Version::new(1, 46, 0)
} else {
assert!(version_str.starts_with("beta") || version_str.starts_with("master"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "nightly"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't intend to benchmark nightlies with bench_published (and this matches the incremental check above).

@Mark-Simulacrum Mark-Simulacrum merged commit 2bb6aaf into rust-lang:master Jul 20, 2020
@Mark-Simulacrum Mark-Simulacrum deleted the skip-rustdoc-early branch July 20, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc build failed on 1.45.0
2 participants
@Mark-Simulacrum @jyn514